Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752061AbYKLGIp (ORCPT ); Wed, 12 Nov 2008 01:08:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751055AbYKLGIg (ORCPT ); Wed, 12 Nov 2008 01:08:36 -0500 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:52596 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751026AbYKLGIf (ORCPT ); Wed, 12 Nov 2008 01:08:35 -0500 Date: Wed, 12 Nov 2008 15:07:55 +0900 From: KAMEZAWA Hiroyuki To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "balbir@linux.vnet.ibm.com" , "nishimura@mxp.nes.nec.co.jp" , "menage@google.com" Subject: Re: [RFC][PATCH 1/6] memcg: free all at rmdir Message-Id: <20081112150755.b64510d5.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20081112122656.c6e56248.kamezawa.hiroyu@jp.fujitsu.com> References: <20081112122606.76051530.kamezawa.hiroyu@jp.fujitsu.com> <20081112122656.c6e56248.kamezawa.hiroyu@jp.fujitsu.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 2.5.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 528 Lines: 24 On Wed, 12 Nov 2008 12:26:56 +0900 KAMEZAWA Hiroyuki wrote: > move_account: > + /* should free all ? */ > + if (!mem->on_rmdir) > + goto try_to_free; > + This must be == if (!mem->on_rmdir) goto try_to_free; move_account: == Sorry. -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/