Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753210AbYKLJXv (ORCPT ); Wed, 12 Nov 2008 04:23:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751610AbYKLJXe (ORCPT ); Wed, 12 Nov 2008 04:23:34 -0500 Received: from ey-out-2122.google.com ([74.125.78.25]:29868 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751605AbYKLJXb (ORCPT ); Wed, 12 Nov 2008 04:23:31 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=fLv1pScJyAlyJkqYc7HV4FuXNX33oVpGLYq8svrQ/qJ84Vnlc5q1e5ijiKuyW5xeHH rMHBAoluyT6Cp3De7ots6/Q/RexVZMfYDdYZpul2pC6+oASM1qPGAbkqxF2c2d1byECm 7FWn6HSXE3MsYGTqubQFdaciUBcwqZwhIPnJw= Message-ID: <491AA08D.9080401@gmail.com> Date: Wed, 12 Nov 2008 10:23:25 +0100 From: Jiri Slaby User-Agent: Thunderbird 2.0.0.17 (X11/20080922) MIME-Version: 1.0 To: Andrew Morton CC: Jiri Kosina , vda.linux@googlemail.com, hugh@veritas.com, torvalds@linux-foundation.org, deller@gmx.de, jer@gentoo.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Who broke cb8f488c33 patch? (was Re: [PATCH 1/1] USBHID: correct start/stop cycle) References: <1225579306-28524-1-git-send-email-jirislaby@gmail.com> <200811022024.31528.vda.linux@googlemail.com> <200811120124.41222.vda.linux@googlemail.com> <20081111165038.fb1f2f45.akpm@linux-foundation.org> In-Reply-To: <20081111165038.fb1f2f45.akpm@linux-foundation.org> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1106 Lines: 27 On 11/12/2008 01:50 AM, Andrew Morton wrote: >>> let's fix it for good. >>> Signed-off-by: Denys Vlasenko >>> --- linux-2.6.28-rc4/mm/mmap.c Mon Nov 10 01:36:15 2008 >>> +++ linux-2.6.28-rc4.fix/mm/mmap.c Wed Nov 12 01:21:39 2008 >>> @@ -1704,7 +1704,7 @@ >>> vma = find_vma_prev(mm, addr, &prev); >>> if (vma && (vma->vm_start <= addr)) >>> return vma; >>> - if (expand_stack(prev, addr)) >>> + if (!prev || expand_stack(prev, addr)) >>> return NULL; >>> if (prev->vm_flags & VM_LOCKED) { >>> if (mlock_vma_pages_range(prev, addr, prev->vm_end) < 0) > > It looks like this was caused by me fixing rejects. That was the fancy > include-lots-of-context-so-it-wont-apply patch. Great, this one got fixed. Helge, did you proceed with bisecting which another commit breaks parics while having this one applied? Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/