Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752174AbYKLRQG (ORCPT ); Wed, 12 Nov 2008 12:16:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751476AbYKLRPv (ORCPT ); Wed, 12 Nov 2008 12:15:51 -0500 Received: from terminus.zytor.com ([198.137.202.10]:43689 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751468AbYKLRPu (ORCPT ); Wed, 12 Nov 2008 12:15:50 -0500 Message-ID: <491B0E6F.2010301@zytor.com> Date: Wed, 12 Nov 2008 09:12:15 -0800 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Mikael Pettersson CC: Ingo Molnar , Hiroshi Shimamoto , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] x86: ia32_signal: remove unnecessary padding References: <491A48E9.8020909@ct.jp.nec.com> <491A496B.5010505@ct.jp.nec.com> <20081112112937.GA6372@elte.hu> <18714.52512.213371.33245@harpo.it.uu.se> In-Reply-To: <18714.52512.213371.33245@harpo.it.uu.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 473 Lines: 14 Mikael Pettersson wrote: > It does cause each signal delivery to leak 2 uninitialised > kernel bytes to the end of retcode[], which seems unnecessary. Not just unnecessary, it is a huge no-no for security. NAK on this. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/