Date: Wed, 12 Nov 2008 17:40:10 +0000
From: Nick Warne <nick@ukfsn.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make Dell keyboard repeat quirk apply to a wider range
 of hardware
Message-ID: <20081112174010.209149e1@palantir.linicks.net>
In-Reply-To: <20081112172712.GA16382@srcf.ucam.org>
References: <20081111074702.75e71055@sauron.linicks.net>
	<20081112131427.1bbc2a7c@palantir.linicks.net>
	<20081112165650.GA15594@srcf.ucam.org>
	<20081112172429.674c4ff3@palantir.linicks.net>
	<20081112172712.GA16382@srcf.ucam.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1266
Lines: 39

On Wed, 12 Nov 2008 17:27:12 +0000
Matthew Garrett <mjg59@srcf.ucam.org> wrote:

> On Wed, Nov 12, 2008 at 05:24:29PM +0000, Nick Warne wrote:
> 
> > But how you determine if these certain laptops produce a keypress
> > release I don't know with having all of them at hand...
> 
> The quirk is only applied to a small number of keys which wouldn't
> want autorepeat anyway, so it's pretty clearly harmless even if the
> hardware works sanely.
> 
> > So it needs BOTH 'Dell Inc.' and 'Dell Computer Corporation' to
> > cover these laptops (I guess), as per the info I got from people
> > running dmidecode:
> 
> That's what the patch adds. I don't have appropriate hardware to test.
> 

Yes.

I have copied to the Ubuntu bug report (they already pushed out your
first patch) so hopefully people there can test it as I don't have this
hardware either.

BTW, what was it that produced this issue in the first place?  All
previous kernel versions worked OK?

Thanks,

Nick

-- 
Free Software Foundation Associate Member 5508
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/