Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754825AbYKLTBm (ORCPT ); Wed, 12 Nov 2008 14:01:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753703AbYKLTBW (ORCPT ); Wed, 12 Nov 2008 14:01:22 -0500 Received: from rcsinet12.oracle.com ([148.87.113.124]:47809 "EHLO rgminet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753054AbYKLTBT (ORCPT ); Wed, 12 Nov 2008 14:01:19 -0500 X-Greylist: delayed 7825 seconds by postgrey-1.27 at vger.kernel.org; Wed, 12 Nov 2008 14:01:19 EST Date: Wed, 12 Nov 2008 10:59:45 -0800 From: Randy Dunlap To: Boaz Harrosh Cc: James Bottomley , Andrew Morton , =?ISO-8859-1?Q?J=F6rn?= Engel , open-osd development , Mike Christie , FUJITA Tomonori , Jeff Garzik , linux-scsi , Sami.Iren@seagate.com, linux-kernel Subject: Re: [PATCH 03/18 ver3] libosd: OSDv1 Headers Message-Id: <20081112105945.f4ec0089.randy.dunlap@oracle.com> In-Reply-To: <491AD697.9030305@panasas.com> References: <491073BB.4000900@panasas.com> <1225817046-5946-1-git-send-email-bharrosh@panasas.com> <4916F934.4090205@panasas.com> <20081110092940.57b4c169.randy.dunlap@oracle.com> <491AD697.9030305@panasas.com> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.5.0 (GTK+ 2.12.0; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Source-IP: acsmt707.oracle.com [141.146.40.85] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090206.491B27C9.0037:SCFSTAT928724,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4225 Lines: 151 On Wed, 12 Nov 2008 15:13:59 +0200 Boaz Harrosh wrote: > > Headers only patch. > > osd_protocol.h > Contains a C-fied definition of the T10 OSD standard > osd_types.h > Contains CPU order common used types > osd_initiator.h > API definition of the osd_initiator library > osd_sec.h > Contains High level API for the security manager. > > [Note that checkpatch spews errors on things that are valid in this context > and will not be fixed] > > Signed-off-by: Boaz Harrosh > Reviewed-by: Benny Halevy > --- > include/scsi/osd_initiator.h | 332 ++++++++++++++++++++++++++++ > include/scsi/osd_protocol.h | 497 ++++++++++++++++++++++++++++++++++++++++++ > include/scsi/osd_sec.h | 45 ++++ > include/scsi/osd_types.h | 40 ++++ > 4 files changed, 914 insertions(+), 0 deletions(-) > create mode 100644 include/scsi/osd_initiator.h > create mode 100644 include/scsi/osd_protocol.h > create mode 100644 include/scsi/osd_sec.h > create mode 100644 include/scsi/osd_types.h > diff --git a/include/scsi/osd_protocol.h b/include/scsi/osd_protocol.h > new file mode 100644 > index 0000000..ce678c5 > --- /dev/null > +++ b/include/scsi/osd_protocol.h > @@ -0,0 +1,497 @@ > +#ifndef __OSD_PROTOCOL_H__ > +#define __OSD_PROTOCOL_H__ ... > +/* osd2r03: 5.2.1 Overview */ > +struct osd_cdb_head { > + struct scsi_varlen_cdb_hdr varlen_cdb; > +/*10*/ u8 options; > + u8 command_specific_options; > + u8 timestamp_control; > +/*13*/ u8 reserved1[3]; > +/*16*/ __be64 partition; > +/*24*/ __be64 object; > +/*32*/ union { /* V1 vs V2 alignment differences */ > + struct __osdv1_cdb_addr_len { > +/*32*/ __be32 list_identifier;/* Rarely used */ > +/*36*/ __be64 length; > +/*44*/ __be64 start_address; > + } __packed v1; > + }; > +/*52*/ union { /* selected attributes mode Page/List/Single */ > + struct osd_attributes_page_mode { > +/*52*/ __be32 get_attr_page; > +/*56*/ __be32 get_attr_alloc_length; > +/*60*/ osd_cdb_offset get_attr_offset; > + > +/*64*/ __be32 set_attr_page; > +/*68*/ __be32 set_attr_id; > +/*72*/ __be32 set_attr_length; > +/*76*/ osd_cdb_offset set_attr_offset; > + } __packed attrs_page; > + > + struct osd_attributes_list_mode { > +/*52*/ __be32 get_attr_desc_bytes; > +/*56*/ osd_cdb_offset get_attr_desc_offset; > + > +/*60*/ __be32 get_attr_alloc_length; > +/*64*/ osd_cdb_offset get_attr_offset; > + > +/*68*/ __be32 set_attr_bytes; > +/*72*/ osd_cdb_offset set_attr_offset; > + __be32 not_used; > + } __packed attrs_list; > + > + /* osd2r03:5.2.4.2 Set one attribute value using CDB fields */ > + struct osd_attributes_cdb_mode { > +/*52*/ __be32 set_attr_page; > +/*56*/ __be32 set_attr_id; > +/*60*/ __be16 set_attr_len; > +/*62*/ u8 set_attr_val[80-62]; ugh > + } __packed attrs_cdb; > +/*52*/ u8 get_set_attributes_parameters[80-52]; ugh > + }; > +} __packed; > +/*80*/ > +/* (osd-r10:4.9.2.2) > + * osd2r03:4.11.2.2 Capability format > + */ > +struct osd_capability_head { > + u8 format; /* low nibble */ > + u8 integrity_algorithm__key_version; /* MAKE_BYTE(integ_alg, key_ver) */ > + u8 security_method; > + u8 reserved1; > +/*04*/ struct osd_timestamp expiration_time; > +/*10*/ u8 audit[30-10]; > +/*30*/ u8 discriminator[42-30]; > +/*42*/ struct osd_timestamp object_created_time; > +/*48*/ u8 object_type; > + u8 permissions_bit_mask[54-49]; more of the same > +/*54*/ u8 reserved2; > +/*55*/ u8 object_descriptor_type; /* high nibble */ > +} __packed; > + > +/*56 v1*/ > +struct osdv1_cap_object_descriptor { > + union { > + struct { > +/*56*/ __be32 policy_access_tag; > +/*60*/ __be64 allowed_partition_id; > +/*68*/ __be64 allowed_object_id; > +/*76*/ __be32 reserved; > + } __packed obj_desc; > + > + u8 object_descriptor[80-56];/*24*/ ditto. nice comment ;) > + }; > +} __packed; > +/*80 v1*/ > + > +#endif /* ndef __OSD_PROTOCOL_H__ */ Thanks for the fixes. --- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/