Date: Thu, 13 Nov 2008 08:43:00 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Mark Nelson <markn@au1.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
       Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
       David Brownell <dbrownell@users.sourceforge.net>
Subject: Re: commit "genirq: record trigger type" and powerpc
Message-ID: <20081113074300.GC1723@elte.hu>
References: <200811131730.11506.markn@au1.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200811131730.11506.markn@au1.ibm.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1307
Lines: 33


* Mark Nelson <markn@au1.ibm.com> wrote:

> Hi Ingo,
> 
> I noticed that after commit 0c5d1eb77a8be917b638344a22afe1398236482b 
> (genirq: record trigger type), several of our powerpc platforms now 
> spew out warnings about "No set_type function for IRQ..." (in 
> particular our Cell blades). This is because in our generic platform 
> code we call set_irq_type() with information from the device tree 
> when we establish the interrupt mappings; but we do this regardless 
> of whether the PIC can actually set a type (it might irrelevant 
> because the type is essentially hardcoded or as in the case for Cell 
> the interrupts are just messages being past around that have no real 
> concept of type, or we could even be dealing with a virtual PIC as 
> on the PS3).
> 
> So, would it be possible to turn the:
> 
> 	pr_warning("No set_type function... 
> 
> into a pr_debug() in kernel/irq/manage.c so when our users upgrade 
> to newer kernels they don't get scared by a whole bunch of new 
> warnings?

Sure, please send a patch with a changelog.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/