Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753208AbYKMLdk (ORCPT ); Thu, 13 Nov 2008 06:33:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751670AbYKMLdb (ORCPT ); Thu, 13 Nov 2008 06:33:31 -0500 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:39946 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751368AbYKMLd3 (ORCPT ); Thu, 13 Nov 2008 06:33:29 -0500 Date: Thu, 13 Nov 2008 20:32:47 +0900 From: KAMEZAWA Hiroyuki To: Izik Eidus Cc: Izik Eidus , Avi Kivity , Andrea Arcangeli , Christoph Lameter , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, chrisw@redhat.com, izike@qumranet.com Subject: Re: [PATCH 2/4] Add replace_page(), change the mapping of pte from one page into another Message-Id: <20081113203247.b5e24e26.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <491C038F.5020007@redhat.com> References: <1226409701-14831-1-git-send-email-ieidus@redhat.com> <1226409701-14831-2-git-send-email-ieidus@redhat.com> <1226409701-14831-3-git-send-email-ieidus@redhat.com> <20081111114555.eb808843.akpm@linux-foundation.org> <4919F1C0.2050009@redhat.com> <4919F7EE.3070501@redhat.com> <20081111222421.GL10818@random.random> <20081112111931.0e40c27d.kamezawa.hiroyu@jp.fujitsu.com> <491AAA84.5040801@redhat.com> <491AB9D0.7060802@qumranet.com> <20081113151129.35c17962.kamezawa.hiroyu@jp.fujitsu.com> <491C038F.5020007@redhat.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 2.5.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1783 Lines: 62 On Thu, 13 Nov 2008 12:38:07 +0200 Izik Eidus wrote: > > If KSM pages are on radix-tree, it will be accounted automatically. > > Now, we have "Unevictable" LRU and mlocked() pages are smartly isolated into its > > own LRU. So, just doing > > > > - inode's radix-tree > > - make all pages mlocked. > > - provide special page fault handler for your purpose > > > > Well in this version that i am going to merge the pages arent going to > be swappable, > Latter after Ksm will get merged we will make the KsmPages swappable... good to hear > so i think working with cgroups would be effective / useful only when > KsmPages will start be swappable... > Do you agree? > (What i am saying is that right now lets dont count the KsmPages inside > the cgroup, lets do it when KsmPages > will be swappable) > ok. > If you feel this pages should be counted in the cgroup i have no problem > to do it via hooks like page migration is doing. > > thanks. > > > is simple one. But ok, whatever implementation you'll do, I have to check it > > and consider whether it should be tracked or not. Then, add codes to memcg to > > track it or ignore it or comments on your patches ;) > > > > It's helpful to add me to CC: when you post this set again. > > > > Sure will. > If necessary, I'll have to add "ignore in this case" hook in memcg. (ex. checking PageKSM flag in memcg.) If you are sufferred from memcg in your test, cgroup_disable=memory boot option will allow you to disable memcg. Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/