DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=QAP3aLkt9vXVJ7ZMAS4v1UYqNNMAAqSzrEOFfCtgbqVg8U0V5KBCePWilULd4DWUV5
         D0jFSumjeWLBGRNc+z8mR4nQmgSDB1A7RPqTJHhgScUE3l5tQSxMDp+t/gDjV1nPO6K7
         7BtD7vT1uE2/rgvWr3tRLlu4wmSTju6WbroSs=
Message-ID: <8bd0f97a0811130755t1e75b5b9tbdcf5189feea8b38@mail.gmail.com>
Date: Thu, 13 Nov 2008 10:55:49 -0500
From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Atsushi Nemoto" <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] mtd: unify mtd partition/device registration
Cc: vapier@gentoo.org, linux-mtd@lists.infradead.org, dwmw2@infradead.org,
       linux-kernel@vger.kernel.org
In-Reply-To: <20081114.005132.78730934.anemo@mba.ocn.ne.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20081113.224350.18312549.anemo@mba.ocn.ne.jp>
	 <20081113.232823.125897716.anemo@mba.ocn.ne.jp>
	 <8bd0f97a0811130651k11c52a53j91c80cf196e9f66a@mail.gmail.com>
	 <20081114.005132.78730934.anemo@mba.ocn.ne.jp>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1390
Lines: 36

On Thu, Nov 13, 2008 at 10:51, Atsushi Nemoto wrote:
> On Thu, 13 Nov 2008 09:51:01 -0500, "Mike Frysinger" wrote:
>> > Automatic fallback to mtd_device in parse_mtd() is convenient but
>> > somewhat unflexible...
>>
>> we could just have it do it all the time.  i dont see a problem with
>> exposing the entire block device the whole time ?  i know for the
>> driver or two of mine, i'm fine with it.
>>
>> ...
>>        ret = parse_mtd_partitions(mtd, probe_types, &parts, 0);
>>        if (ret > 0) {
>>                ret = add_mtd_partitions(mtd, parts, ret);
>>                kfree(parts);
>>        } else if (nr_parts)
>>                ret = add_mtd_partitions(mtd, parts, nr_parts);
>>        if (ret)
>>                return ret;
>> #endif
>>
>>        return add_mtd_device(mtd);
>
> I'm OK with this.  But not sure all current mtd partition users.
>
> Are you going to convert all parse_mtd_partitions() call?  Maybe some
> people do not want to change /dev/mtd numbers...

if it's a real concern, we can make it optional.  i'll post patches to
convert physmap and my drivers as those are the only ones i can
actually test.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/