Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754146AbYKMQmc (ORCPT ); Thu, 13 Nov 2008 11:42:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751829AbYKMQmH (ORCPT ); Thu, 13 Nov 2008 11:42:07 -0500 Received: from mx1.suse.de ([195.135.220.2]:34239 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751662AbYKMQmG (ORCPT ); Thu, 13 Nov 2008 11:42:06 -0500 Date: Thu, 13 Nov 2008 17:42:04 +0100 Message-ID: From: Takashi Iwai To: Pavel Machek Cc: Andres Salomon , Jeremy Katz , Ingo Molnar , Thomas Gleixner , Jordan Crouse , linux-kernel@vger.kernel.org, dsaxena@laptop.org Subject: Re: [PATCH] ALSA: cs5535audio: only build OLPC support if MGEODE_LX is defined In-Reply-To: <20081113163802.GA1734@ucw.cz> References: <20081111140406.GA3244@elte.hu> <20081109201710.4c490f04@debxo> <1226498050.12791.45.camel@aglarond.local> <1226547898.13077.83.camel@aglarond.local> <20081113153714.GA1520@ucw.cz> <20081113111428.59aa36cb@ephemeral> <20081113163802.GA1734@ucw.cz> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2508 Lines: 72 At Thu, 13 Nov 2008 17:38:02 +0100, Pavel Machek wrote: > > On Thu 2008-11-13 11:14:28, Andres Salomon wrote: > > On Thu, 13 Nov 2008 16:54:19 +0100 > > Takashi Iwai wrote: > > > > > At Thu, 13 Nov 2008 16:37:14 +0100, > > > Pavel Machek wrote: > > [...] > > > > > > > > > IMO, the basic problem is rather that the platform and the CPU > > > > > selection is mixed up. The geode GPIO stuff shouldn't belong to > > > > > CPU selection. > > > > > > > > ACK... and suggested patch makes it worse. > > > > > > > > There should be option 'support OLPC' somewhere, and that should > > > > enable the gpio bits. Alsa driver should depend on that one. > > > > > > Any better fix patch is welcome, of course :) > > > This would make save a lot time than writing mails... > > > > > Okay, how about something like the following? > > It is wrong. It is valid & useful to compile kernel for i386 and > expect all the features on OLPC (with small performance hit). Pavel, the background story is that we have some OLPC-specific features currently depending on geode GPIO. Thus, it can't be built for i386, unless GPIO stuff is separated from the CPU selection. Takashi > Pavel > > > This is a temporary work-around until the geode_gpio* calls are moved out > > into a separate config option. We don't want to force generic kernel > > maintainers to have to build a specific OLPC kernel. > > > > Signed-off-by: Andres Salomon > > --- > > sound/pci/cs5535audio/Makefile | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/sound/pci/cs5535audio/Makefile b/sound/pci/cs5535audio/Makefile > > index ccc6422..fda7a94 100644 > > --- a/sound/pci/cs5535audio/Makefile > > +++ b/sound/pci/cs5535audio/Makefile > > @@ -4,7 +4,9 @@ > > > > snd-cs5535audio-y := cs5535audio.o cs5535audio_pcm.o > > snd-cs5535audio-$(CONFIG_PM) += cs5535audio_pm.o > > +ifdef CONFIG_MGEODE_LX > > snd-cs5535audio-$(CONFIG_OLPC) += cs5535audio_olpc.o > > +endif > > > > # Toplevel Module Dependency > > obj-$(CONFIG_SND_CS5535AUDIO) += snd-cs5535audio.o > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/