Date: Thu, 13 Nov 2008 18:12:22 +0100
Message-ID: <s5hk5b71rex.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Andres Salomon <dilinger@queued.net>
Cc: Pavel Machek <pavel@suse.cz>, Jeremy Katz <katzj@redhat.com>,
       Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
       Jordan Crouse <jordan.crouse@amd.com>, linux-kernel@vger.kernel.org,
       dsaxena@laptop.org
Subject: Re: [PATCH] ALSA: cs5535audio: only build OLPC support if MGEODE_LX is defined
In-Reply-To: <s5htzabfuyo.wl%tiwai@suse.de>
References: <20081111125402.GB14989@elte.hu>
	<s5hzlk6pea6.wl%tiwai@suse.de>
	<20081111135306.GA32709@elte.hu>
	<s5hwsfapdoj.wl%tiwai@suse.de>
	<20081111140406.GA3244@elte.hu>
	<20081109201710.4c490f04@debxo>
	<1226498050.12791.45.camel@aglarond.local>
	<s5hbpwlj9w1.wl%tiwai@suse.de>
	<1226547898.13077.83.camel@aglarond.local>
	<s5h63msru7z.wl%tiwai@suse.de>
	<20081113153714.GA1520@ucw.cz>
	<s5h3ahvhb9w.wl%tiwai@suse.de>
	<20081113111428.59aa36cb@ephemeral>
	<s5htzabfuyo.wl%tiwai@suse.de>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1436
Lines: 49

At Thu, 13 Nov 2008 17:31:59 +0100,
I wrote:
> 
> At Thu, 13 Nov 2008 11:14:28 -0500,
> Andres Salomon wrote:
> > 
> > On Thu, 13 Nov 2008 16:54:19 +0100
> > Takashi Iwai <tiwai@suse.de> wrote:
> > 
> > > At Thu, 13 Nov 2008 16:37:14 +0100,
> > > Pavel Machek wrote:
> > [...]
> > > > 
> > > > > IMO, the basic problem is rather that the platform and the CPU
> > > > > selection is mixed up.  The geode GPIO stuff shouldn't belong to
> > > > > CPU selection.
> > > > 
> > > > ACK... and suggested patch makes it worse.
> > > > 
> > > > There should be option 'support OLPC' somewhere, and that should
> > > > enable the gpio bits. Alsa driver should depend on that one.
> > > 
> > > Any better fix patch is welcome, of course :)
> > > This would make save a lot time than writing mails...
> > > 
> > > 
> > > thanks,
> > > 
> > > Takashi
> > 
> > 
> > Okay, how about something like the following?
> 
> Actually, this is exactly what I made at first.
> But, as asm/olpc.h is already dependent on GEODE, I decided to fix
> rather CONFIG_OLPC.

I forgot another thing.  The cs5535audio.h includes #ifdef CONFIG_OLPC
for OLPC-specific codes.  This has to be fixed as well...


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/