Date: Thu, 13 Nov 2008 20:14:16 +0200
From: Felipe Balbi <me@felipebalbi.com>
To: Richard Purdie <rpurdie@linux.intel.com>
Cc: Felipe Balbi <me@felipebalbi.com>, linux-kernel@vger.kernel.org,
       Felipe Balbi <felipe.balbi@nokia.com>, Anton Vorontsov <cbou@mail.ru>,
       David Woodhouse <dwmw2@infradead.org>, Greg KH <greg@kroah.com>,
       Pierre Ossman <drzeus@drzeus.cx>
Subject: Re: [PATCH] led: simplify led_trigger_register_simple
Message-ID: <20081113181407.GC17166@frodo>
Reply-To: me@felipebalbi.com
References: <1226545753-6640-1-git-send-email-me@felipebalbi.com> <1226579912.5402.21.camel@dax.rpnet.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1226579912.5402.21.camel@dax.rpnet.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 743
Lines: 16

On Thu, Nov 13, 2008 at 12:38:32PM +0000, Richard Purdie wrote:
> The simple triggers were designed to cause minimum interference to the
> usually external subsystem code they were added into. As an example this
> meant things like errors were just handled gracefully with a printk
> warning and did not take down the whole subsystem. I therefore don't
> regard this patch as a simplification, more a complication.

That's a matter of changing the return ERR_PTR(err); back to a printk.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/