Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752517AbYKMVyf (ORCPT ); Thu, 13 Nov 2008 16:54:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755206AbYKMVyJ (ORCPT ); Thu, 13 Nov 2008 16:54:09 -0500 Received: from mho-01-bos.mailhop.org ([63.208.196.178]:55051 "EHLO mho-01-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754907AbYKMVyH (ORCPT ); Thu, 13 Nov 2008 16:54:07 -0500 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 69.181.40.92 X-Report-Abuse-To: abuse@dyndns.com (see http://www.mailhop.org/outbound/abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+MwJY6fk3pynEhakKTOzxs Date: Thu, 13 Nov 2008 13:54:03 -0800 From: Tony Lindgren To: Samuel Ortiz Cc: David Brownell , lkml , linux-omap@vger.kernel.org Subject: Re: [patch 2.6.28-rc3-git] twl4030-core: allow reading entire register banks Message-ID: <20081113215403.GJ3106@atomide.com> References: <200811071400.04181.david-b@pacbell.net> <20081108003209.GB5993@sortiz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081108003209.GB5993@sortiz.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2743 Lines: 73 * Samuel Ortiz [081107 16:30]: > On Fri, Nov 07, 2008 at 02:00:03PM -0800, David Brownell wrote: > > From: David Brownell > > > > Minor change to the TWL4030 utility interface: support reads > > of all 256 bytes in each register bank (vs just 255). This > > can help when debugging, but is otherwise a NOP. > Applied to my for-next branch. > Thanks David. Pushing also to linux-omap while waiting for this patch to fall down from the mainline kernel. Tony > Cheers, > Samuel. > > > > Signed-off-by: David Brownell > > --- > > drivers/mfd/twl4030-core.c | 4 ++-- > > include/linux/i2c/twl4030.h | 4 ++-- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > --- a/drivers/mfd/twl4030-core.c > > +++ b/drivers/mfd/twl4030-core.c > > @@ -233,7 +233,7 @@ extern void twl4030_power_init(struct tw > > * > > * Returns the result of operation - 0 is success > > */ > > -int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes) > > +int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes) > > { > > int ret; > > int sid; > > @@ -282,7 +282,7 @@ EXPORT_SYMBOL(twl4030_i2c_write); > > * > > * Returns result of operation - num_bytes is success else failure. > > */ > > -int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes) > > +int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes) > > { > > int ret; > > u8 val; > > --- a/include/linux/i2c/twl4030.h > > +++ b/include/linux/i2c/twl4030.h > > @@ -78,8 +78,8 @@ int twl4030_i2c_read_u8(u8 mod_no, u8 *v > > * IMPORTANT: For twl4030_i2c_write(), allocate num_bytes + 1 > > * for the value, and populate your data starting at offset 1. > > */ > > -int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes); > > -int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes); > > +int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes); > > +int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes); > > > > /*----------------------------------------------------------------------*/ > > > > -- > Intel Open Source Technology Centre > http://oss.intel.com/ > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/