Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754785AbYKMWFb (ORCPT ); Thu, 13 Nov 2008 17:05:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751866AbYKMWFU (ORCPT ); Thu, 13 Nov 2008 17:05:20 -0500 Received: from nf-out-0910.google.com ([64.233.182.185]:55223 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374AbYKMWFT (ORCPT ); Thu, 13 Nov 2008 17:05:19 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=GX0cMvkX2/VmZU9gWGq+HdOLE2gEo132auHHh20FQOnIwAvn+7rLMmtBOeh67OpSCy 6qnMkqO5w5+uG2AS4K620SggCG1dra88i/aYOUvgBNeHIYd5lk/aw0VBQc9Td0GAWOIS 1Q7ElMpUgmJ+1JCRl/JtUZhyBzuKxz4EoV9Gg= Message-ID: <491CA495.7010007@gmail.com> Date: Thu, 13 Nov 2008 23:05:09 +0100 From: Jiri Slaby User-Agent: Thunderbird 2.0.0.17 (X11/20080922) MIME-Version: 1.0 To: Alan Stern CC: Andi Kleen , Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: don't grab devices with no input References: In-Reply-To: X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 691 Lines: 21 On 11/13/2008 10:37 PM, Alan Stern wrote: >> + for (n = 0; n < interface->desc.bNumEndpoints; n++) >> + if (usb_endpoint_dir_in(&interface->endpoint[n].desc)) >> + has_in++; >> + if (!has_in) { >> + dev_err(&intf->dev, "couldn't find an input interrupt " >> + "endpoint"); >> + return -ENODEV; >> + } >> + > > Do you want to use usb_endpoint_is_int_in() instead? It matches the > error message more closely. Yes, good catch, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/