Date: Fri, 14 Nov 2008 00:30:48 +0100
Message-ID: <s5hzlk3kxuf.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andres Salomon <dilinger@queued.net>, Pavel Machek <pavel@suse.cz>,
       Jeremy Katz <katzj@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
       Jordan Crouse <jordan.crouse@amd.com>, linux-kernel@vger.kernel.org,
       dsaxena@laptop.org
Subject: Re: [PATCH] ALSA: cs5535audio: only build OLPC support if	MGEODE_LX is defined
In-Reply-To: <20081113190339.GE17851@elte.hu>
References: <20081109201710.4c490f04@debxo>
	<1226498050.12791.45.camel@aglarond.local>
	<s5hbpwlj9w1.wl%tiwai@suse.de>
	<1226547898.13077.83.camel@aglarond.local>
	<s5h63msru7z.wl%tiwai@suse.de>
	<20081113153714.GA1520@ucw.cz>
	<s5h3ahvhb9w.wl%tiwai@suse.de>
	<20081113111428.59aa36cb@ephemeral>
	<20081113163802.GA1734@ucw.cz>
	<20081113120147.2ecde3c8@ephemeral>
	<20081113190339.GE17851@elte.hu>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1938
Lines: 59

At Thu, 13 Nov 2008 20:03:39 +0100,
Ingo Molnar wrote:
> 
> 
> * Andres Salomon <dilinger@queued.net> wrote:
> 
> > On Thu, 13 Nov 2008 17:38:02 +0100
> > Pavel Machek <pavel@suse.cz> wrote:
> > 
> > > On Thu 2008-11-13 11:14:28, Andres Salomon wrote:
> > > > On Thu, 13 Nov 2008 16:54:19 +0100
> > > > Takashi Iwai <tiwai@suse.de> wrote:
> > > > 
> > > > > At Thu, 13 Nov 2008 16:37:14 +0100,
> > > > > Pavel Machek wrote:
> > > > [...]
> > > > > > 
> > > > > > > IMO, the basic problem is rather that the platform and the CPU
> > > > > > > selection is mixed up.  The geode GPIO stuff shouldn't belong
> > > > > > > to CPU selection.
> > > > > > 
> > > > > > ACK... and suggested patch makes it worse.
> > > > > > 
> > > > > > There should be option 'support OLPC' somewhere, and that should
> > > > > > enable the gpio bits. Alsa driver should depend on that one.
> > > > > 
> > > > > Any better fix patch is welcome, of course :)
> > > > > This would make save a lot time than writing mails...
> > > 
> > > > 
> > > > Okay, how about something like the following?
> > > 
> > > It is wrong. It is valid & useful to compile kernel for i386 and
> > > expect all the features on OLPC (with small performance hit).
> > 
> > No one's debating that.  That requires additional work that will 
> > take longer, however.
> 
> i've zapped this patch meanwhile:
> 
>  1355c96: x86/olpc: make CONFIG_OLPC dependent on CONFIG_MGEODE_LX
> 
> because it cripples the ability to run distribution kernels on the 
> OLPC.

OK, I reverted also all relevant changes for cs5535audio driver now.
The patches are saved in topic/cs5535audio branch, though.

Let's fix OLPC-geode coupling first.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/