Message-ID: <491CC0B6.8020400@ru.mvista.com>
Date: Fri, 14 Nov 2008 03:05:10 +0300
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
User-Agent: Thunderbird 2.0.0.17 (Windows/20080914)
MIME-Version: 1.0
To: David Daney <ddaney@caviumnetworks.com>
Cc: linux-kernel@vger.kernel.org, linux-mips <linux-mips@linux-mips.org>
Subject: Re: [PATCH] New IDE/block driver for OCTEON SOC Compact Flash interface.
References: <491C7F28.2070507@caviumnetworks.com>
In-Reply-To: <491C7F28.2070507@caviumnetworks.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1308
Lines: 34

Hello.

David Daney wrote:

> As part of our efforts to get the Cavium OCTEON processor support
> merged (see: http://marc.info/?l=linux-mips&m=122600487218824), we
> have this CF driver for your consideration.
>
> Most OCTEON variants have *no* DMA or interrupt support on the CF
> interface so a simple bit-banging approach is taken.  Although if DMA is
> available, we do take advantage of it.
>
> The register definitions are part of the chip support patch set
> mentioned above, and are not included here.
>
> At this point I would like to get feedback as to whether this is a
> good approach for the CF driver, or perhaps generate ideas about other
> possible approaches.

   It's totally unacceptable for drivers/ide/ as this is self-containeed 
driver no using IDE core for anything, so this can only fit well to 
drivers/block/.
OTOH, CF support via self-contained driver is certainly a waste of code 
since IDE core and (libata) are here to drive the CF devices as well. 
What we need is a "normal" IDE or libata (at your option) driver.

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/