Date: Thu, 13 Nov 2008 16:21:28 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: ananth@in.ibm.com, jkenisto@us.ibm.com, davem@davemloft.net,
       linux-kernel@vger.kernel.org, systemtap@sources.redhat.com,
       rusty@rustcorp.com.au
Subject: Re: [PATCH 2/7] kprobes: Add kprobe_insn_mutex and cleanup
 arch_remove_kprobe()
Message-Id: <20081113162128.28e508ca.akpm@linux-foundation.org>
In-Reply-To: <4919F175.2050009@redhat.com>
References: <4919F175.2050009@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1068
Lines: 27

On Tue, 11 Nov 2008 15:56:21 -0500
Masami Hiramatsu <mhiramat@redhat.com> wrote:

> Add kprobe_insn_mutex for protecting kprobe_insn_pages hlist, and remove
> kprobe_mutex from architecture dependent code.
> 
> This allows us to call arch_remove_kprobe() (and free_insn_slot) while holding
> kprobe_mutex.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
> ---
>  arch/arm/kernel/kprobes.c     |    2 --
>  arch/ia64/kernel/kprobes.c    |    8 +++++---
>  arch/powerpc/kernel/kprobes.c |    7 ++++---
>  arch/s390/kernel/kprobes.c    |    7 ++++---
>  arch/x86/kernel/kprobes.c     |    7 ++++---
>  include/linux/kprobes.h       |    1 -
>  kernel/kprobes.c              |   25 +++++++++++++++++++++----

For some reasons sparc64 never had this mutex.  You've checked that
sparc64 will be OK after this change?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/