Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754639AbYKNRfM (ORCPT ); Fri, 14 Nov 2008 12:35:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751159AbYKNRe7 (ORCPT ); Fri, 14 Nov 2008 12:34:59 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:47317 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750918AbYKNRe6 (ORCPT ); Fri, 14 Nov 2008 12:34:58 -0500 Date: Fri, 14 Nov 2008 12:34:22 -0500 From: Christoph Hellwig To: Hugh Dickins Cc: Andrew Morton , Willy Tarreau , Christoph Hellwig , Peter Cordes , Bodo Eggert <7eggert@gmx.de>, David Newall , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-mm Subject: Re: [PATCH 2.6.28?] don't unlink an active swapfile Message-ID: <20081114173422.GA22868@infradead.org> References: <20081018003117.GC26067@cordes.ca> <20081018051800.GO24654@1wt.eu> <20081018204948.GA22140@infradead.org> <20081018205647.GA29946@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 15 On Fri, Nov 14, 2008 at 02:37:22AM +0000, Hugh Dickins wrote: > Peter Cordes is sorry that he rm'ed his swapfiles while they were in use, > he then had no pathname to swapoff. It's a curious little oversight, but > not one worth a lot of hackery. Kudos to Willy Tarreau for turning this > around from a discussion of synthetic pathnames to how to prevent unlink. > Mimic immutable: prohibit unlinking an active swapfile in may_delete() > (and don't worry my little head over the tiny race window). Looks good (but I think I already said this before) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/