Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754879AbYKNSDz (ORCPT ); Fri, 14 Nov 2008 13:03:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751466AbYKNSDr (ORCPT ); Fri, 14 Nov 2008 13:03:47 -0500 Received: from extu-mxob-2.symantec.com ([216.10.194.135]:48277 "EHLO extu-mxob-2.symantec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751040AbYKNSDq (ORCPT ); Fri, 14 Nov 2008 13:03:46 -0500 Date: Fri, 14 Nov 2008 18:02:26 +0000 (GMT) From: Hugh Dickins X-X-Sender: hugh@blonde.site To: Christoph Hellwig cc: Andrew Morton , Willy Tarreau , Peter Cordes , Bodo Eggert <7eggert@gmx.de>, David Newall , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-mm Subject: Re: [PATCH 2.6.28?] don't unlink an active swapfile In-Reply-To: <20081114173422.GA22868@infradead.org> Message-ID: References: <20081018003117.GC26067@cordes.ca> <20081018051800.GO24654@1wt.eu> <20081018204948.GA22140@infradead.org> <20081018205647.GA29946@1wt.eu> <20081114173422.GA22868@infradead.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1132 Lines: 22 On Fri, 14 Nov 2008, Christoph Hellwig wrote: > On Fri, Nov 14, 2008 at 02:37:22AM +0000, Hugh Dickins wrote: > > Peter Cordes is sorry that he rm'ed his swapfiles while they were in use, > > he then had no pathname to swapoff. It's a curious little oversight, but > > not one worth a lot of hackery. Kudos to Willy Tarreau for turning this > > around from a discussion of synthetic pathnames to how to prevent unlink. > > Mimic immutable: prohibit unlinking an active swapfile in may_delete() > > (and don't worry my little head over the tiny race window). > > Looks good (but I think I already said this before) Thanks. Indeed you did. I wondered whether to add an Acked-by in your name, but I think different people have understandably different positions on the etiquette of translating "Looks good" into "Acked-by"; so not knowing your position, I just Cc'ed you again. Hugh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/