Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755495AbYKNVaL (ORCPT ); Fri, 14 Nov 2008 16:30:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751560AbYKNV36 (ORCPT ); Fri, 14 Nov 2008 16:29:58 -0500 Received: from server.drzeus.cx ([85.8.24.28]:45738 "EHLO smtp.drzeus.cx" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751349AbYKNV35 (ORCPT ); Fri, 14 Nov 2008 16:29:57 -0500 Date: Fri, 14 Nov 2008 22:29:55 +0100 From: Pierre Ossman To: Ben Dooks Cc: linux-kernel@vger.kernel.org, sdhci-devel@list.drzeus.cx, Ben Dooks Subject: Re: [patch 2/7] SDHCI: Print ADMA status and pointer on debug Message-ID: <20081114222955.6c12fdda@mjolnir.drzeus.cx> In-Reply-To: <20081103201010.165171320@fluff.org.uk> References: <20081103200944.099353331@fluff.org.uk> <20081103201010.165171320@fluff.org.uk> X-Mailer: Claws Mail 3.6.0 (GTK+ 2.14.4; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 29 On Mon, 03 Nov 2008 20:09:46 +0000 Ben Dooks wrote: > If using ADMA, then we should print the ADMA error > and current pointer in sdhci_dumpregs() when any > debug is requested. > > Signed-off-by: Ben Dooks > Looks ok. I think that dump routine could use some more TLC to be really useful. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org rdesktop, core developer http://www.rdesktop.org WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/