Date: Fri, 14 Nov 2008 22:48:13 +0100
From: Pierre Ossman <drzeus-mmc@drzeus.cx>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linux-kernel@vger.kernel.org, sdhci-devel@list.drzeus.cx,
       Ben Dooks <ben-linux@fluff.org>
Subject: Re: [patch 5/7] SDHCI: Samsung SDHCI (HSMMC) driver
Message-ID: <20081114224813.063017d7@mjolnir.drzeus.cx>
In-Reply-To: <20081103201010.652101443@fluff.org.uk>
References: <20081103200944.099353331@fluff.org.uk>
	<20081103201010.652101443@fluff.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1381
Lines: 46

On Mon, 03 Nov 2008 20:09:49 +0000
Ben Dooks <ben-linux@fluff.org> wrote:

> +static void sdhci_s3c_sel_sclk(struct sdhci_host *host)
> +{
> +	struct sdhci_s3c *ourhost = to_s3c(host);
> +
> +	/* select sclk */
> +	u32 tmp = readl(host->ioaddr + 0x80);
> +
> +	if ((tmp & (3 << 4)) == (2 << 4))
> +		return;
> +
> +	tmp &= ~(3<<4);
> +	tmp |= (2 << 4);
> +	writel(tmp, host->ioaddr + 0x80);
> +}

No defines for this? This is not terribly readable.

> +	if (pdata->cfg_card)
> +		pdata->cfg_card(ourhost->pdev, host->ioaddr,
> +				ios, host->mmc->card);

What's the deal here? Hosts shouldn't know more about the card than the
MMC core tells them.

Since I have no hardware for this, could you take it upon you to handle
support for these chips? I'd like a MAINTAINERS patch for that as well.

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/