Date: Sat, 15 Nov 2008 19:14:14 +0000
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Pavel Machek <pavel@suse.cz>
Cc: Richard Purdie <rpurdie@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: Fix locking for WM8350
Message-ID: <20081115191414.GA12907@opensource.wolfsonmicro.com>
References: <1226579997-3505-1-git-send-email-broonie@opensource.wolfsonmicro.com> <1226588269-17642-1-git-send-email-broonie@opensource.wolfsonmicro.com> <20081115173110.GD1523@ucw.cz> <20081115175050.GB12466@opensource.wolfsonmicro.com> <20081115185119.GA19900@elf.ucw.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081115185119.GA19900@elf.ucw.cz>
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 887
Lines: 22

On Sat, Nov 15, 2008 at 07:51:20PM +0100, Pavel Machek wrote:
> On Sat 2008-11-15 17:50:50, Mark Brown wrote:

> > Yes, that'd be safer though I'd be surprised to see systems that could
> > trigger it.

> Yes, they are uncommon. They exist; SPARC, IIRC. Plus you need

Exceptionally uncommon with the systems the WM8350 gets used with -
it's a primary PMIC for mobile devices so anything other than
uniprocessor ARM would be surprising.

> barriers on anything SMP... Just use atomic_t.

I was intending to do so next time I spin the patch.  Andrew had some
other comments and I don't have any test systems when I'm not in the
office anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/