Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752562AbYKPH7E (ORCPT ); Sun, 16 Nov 2008 02:59:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751274AbYKPH6w (ORCPT ); Sun, 16 Nov 2008 02:58:52 -0500 Received: from mx2.redhat.com ([66.187.237.31]:36137 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751169AbYKPH6v (ORCPT ); Sun, 16 Nov 2008 02:58:51 -0500 Message-ID: <491FD283.60402@redhat.com> Date: Sun, 16 Nov 2008 09:57:55 +0200 From: Avi Kivity User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Eduardo Habkost CC: Ingo Molnar , "Eric W. Biederman" , Simon Horman , Andrew Morton , Vivek Goyal , Haren Myneni , Andrey Borzenkov , mingo@redhat.com, "Rafael J. Wysocki" , Zachary Amsden , kexec@lists.infradead.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/11] x86: disable virt on kdump and emergency_restart (v3) References: <1226598231-18311-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1226598231-18311-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1093 Lines: 30 Eduardo Habkost wrote: > Hi, > > This is a new spin of the series to disable vmx on kdump and on > emergency_restart. Now we avoid doing the function pointer stuff by > moving 4 small KVM functions to a header, as inline functions. The code > looks much simpler now, but we have to be more careful because some > additional code will run on kdump and reboot even when KVM is never > loaded. > > I haven't tested the SVM changes on AMD CPUs. The changes are really > simple, but some testing is welcome. > > This series is against tip.git#master, that already contains the > nmi_shootdown_cpus() changes I've submitted previously. > > > Looks good. I am slightly uneasy about moving things away from vmx.h and svm.h; can we keep them there and #include those headers directly? -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/