Date: Sun, 16 Nov 2008 12:49:24 -0800 (PST)
Message-Id: <20081116.124924.146154114.davem@davemloft.net>
To: jdb@comx.dk
Cc: miltonm@bga.com, segher@kernel.crashing.org, linux-kernel@vger.kernel.org,
       netdev@vger.kernel.org, bhutchings@solarflare.com
Subject: Re: [PATCH] niu: bitwise or does not imply ordering
From: David Miller <davem@davemloft.net>
In-Reply-To: <1226849525.8189.6.camel@localhost.localdomain>
References: <312268717986b8b45674.846930886.miltonm@bga.com>
	<1226849525.8189.6.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 911
Lines: 25

From: Jesper Dangaard Brouer <jdb@comx.dk>
Date: Sun, 16 Nov 2008 16:32:05 +0100

> 
> I have tested it on the actual hardware, it works...
> 
> I actually agree that we should make it explicit, eventhough DaveM seems
> to disagree on the netdev list.

I'm also not applying this patch for another reason.

This is a knee-jerk reaction patch, purely.  This person
saw the commit and wants to fix only _THIS_ case.

Well guess what?  If you really CARED, you'd go change this
across the whole tree.  This exact construct exists ALL
OVER the kernel.  In fact there are sequences that match
this new NIU code exactly.

Did these people complaining look for those?  No.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/