Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754802AbYKPWTU (ORCPT ); Sun, 16 Nov 2008 17:19:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753832AbYKPWTM (ORCPT ); Sun, 16 Nov 2008 17:19:12 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:53219 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753364AbYKPWTM (ORCPT ); Sun, 16 Nov 2008 17:19:12 -0500 Date: Sun, 16 Nov 2008 22:19:10 +0000 From: Al Viro To: Peter Palfrader , linux-kernel@vger.kernel.org Cc: Linus Torvalds Subject: Re: broken ownership of /proc/sys/ files on 2.6.27 Message-ID: <20081116221910.GQ28946@ZenIV.linux.org.uk> References: <20081116205922.GI28958@anguilla.noreply.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081116205922.GI28958@anguilla.noreply.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1062 Lines: 28 On Sun, Nov 16, 2008 at 09:59:22PM +0100, Peter Palfrader wrote: > Hi, > > on several (probably all) of my systems running a 2.6.27 kernel on at > least i386, amd64, ia64, sparc proc/sys does have files not owned by > root: D'oh... Signed-off-by: Al Viro --- diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c index 94fcfff..06ed10b 100644 --- a/fs/proc/proc_sysctl.c +++ b/fs/proc/proc_sysctl.c @@ -31,6 +31,7 @@ static struct inode *proc_sys_make_inode(struct super_block *sb, inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME; inode->i_flags |= S_PRIVATE; /* tell selinux to ignore this inode */ inode->i_mode = table->mode; + inode->i_uid = inode->i_gid = 0; if (!table->child) { inode->i_mode |= S_IFREG; inode->i_op = &proc_sys_inode_operations; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/