Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755821AbYKPXZe (ORCPT ); Sun, 16 Nov 2008 18:25:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754664AbYKPXY6 (ORCPT ); Sun, 16 Nov 2008 18:24:58 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:46717 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754570AbYKPXY5 (ORCPT ); Sun, 16 Nov 2008 18:24:57 -0500 Date: Sun, 16 Nov 2008 15:23:47 -0800 (PST) From: Linus Torvalds To: Al Viro cc: Peter Palfrader , linux-kernel@vger.kernel.org Subject: Re: Fix broken ownership of /proc/sys/ files In-Reply-To: <20081116221910.GQ28946@ZenIV.linux.org.uk> Message-ID: References: <20081116205922.GI28958@anguilla.noreply.org> <20081116221910.GQ28946@ZenIV.linux.org.uk> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 854 Lines: 24 On Sun, 16 Nov 2008, Al Viro wrote: > > D'oh... So I applied this, but I wonder if it might not be nice to make new_inode() (or rather - 'alloc_inode()') initialize some more of the really core members. We already initialize a _lot_ of fields, including fields that most filesystem would likely end up re-initializing when reading an inode (like i_size and i_nlink). Maybe it would be more sensible to initialize i_gid/uid there too, when we are guaranteed to have that cacheline dirty anyway (because we're initializing everything around those fields). But I guess it's not a huge deal. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/