Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756539AbYKQEXK (ORCPT ); Sun, 16 Nov 2008 23:23:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755988AbYKQEW4 (ORCPT ); Sun, 16 Nov 2008 23:22:56 -0500 Received: from gate.crashing.org ([63.228.1.57]:55550 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755607AbYKQEWz (ORCPT ); Sun, 16 Nov 2008 23:22:55 -0500 Subject: Re: [PATCH] sparse_irq aka dyn_irq v13 From: Benjamin Herrenschmidt To: "H. Peter Anvin" Cc: Yinghai Lu , Andrew Morton , mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org, travis@sgi.com In-Reply-To: <4920B15E.6090200@zytor.com> References: <491434FB.2050904@kernel.org> <20081107124957.GA21709@elte.hu> <49168BD3.5010204@kernel.org> <20081109073813.GA17180@elte.hu> <86802c440811090003g5ac53822y852a4c1096228f8b@mail.gmail.com> <20081110094033.GL22392@elte.hu> <20081110015511.453a801e.akpm@linux-foundation.org> <4918065A.6050402@kernel.org> <20081110100329.GA19970@elte.hu> <491A9F87.8040403@kernel.org> <20081112120814.GG11352@elte.hu> <491C8B38.9060901@kernel.org> <20081113131850.d94fb229.akpm@linux-foundation.org> <1226869137.7178.175.camel@pasglop> <4920B069.5020203@kernel.org> <4920B15E.6090200@zytor.com> Content-Type: text/plain Date: Mon, 17 Nov 2008 15:22:21 +1100 Message-Id: <1226895741.7178.183.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1196 Lines: 28 On Sun, 2008-11-16 at 15:48 -0800, H. Peter Anvin wrote: > Yinghai Lu wrote: > > 2. make irq number is bus/devfn/idx, and every dev func will use 12bit range, irq number is relatively fixed not like current MSI irq creating is some kind of floating from NR_IRQS too. > > 2 is *STILL WRONG*, dammit! > > You keep bringing this one up, but our PCI addressing is > *DOMAIN*/bus/devfn -- it falls flat on its face when you have more than > 16 PCI domains. CAN WE PLEASE STOP WITH THIS FOOLISHNESS NOW! Besides, the relationship between PCI location and IRQ numbers seems to be an x86 thingy ... don't bring that into the generic code please ! IRQ numbers are arbitrary, some platforms make up numbers out of the blue, or they can be hypervisor internal tokens etc... The only sane way to handle this generically IMHO is to do what we do on powerpc (and I think sparc64) which is to totally disconnect the HW number from the "linux" number. Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/