Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756145AbYKQLSP (ORCPT ); Mon, 17 Nov 2008 06:18:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753199AbYKQLSA (ORCPT ); Mon, 17 Nov 2008 06:18:00 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:50355 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753189AbYKQLR7 (ORCPT ); Mon, 17 Nov 2008 06:17:59 -0500 Date: Mon, 17 Nov 2008 12:17:47 +0100 From: Ingo Molnar To: "Aneesh Kumar K.V" Cc: rostedt@goodmis.org, akpm@linux-foundation.org, fweisbec@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix writing to trace/trace_options Message-ID: <20081117111747.GN28786@elte.hu> References: <1226831883-26362-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20081116104604.GA25788@skywalker> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081116104604.GA25788@skywalker> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00,DNS_FROM_SECURITYSAGE autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 0.0 DNS_FROM_SECURITYSAGE RBL: Envelope sender in blackholes.securitysage.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1600 Lines: 39 * Aneesh Kumar K.V wrote: > On Sun, Nov 16, 2008 at 04:07:58PM +0530, Aneesh Kumar K.V wrote: > > writing to trace/trace_options use the index of the array > > to find the value of the flag. With branch tracer flag > > defined conditionally, this breaks writing to trace_options > > with branch tracer disabled. > > > > Signed-off-by: Aneesh Kumar K.V > > tg export didn't add numbering to the patch based on dependency. > So the series is in the below order > > [PATCH] ftrace: add proper bin iterator support > [PATCH] ftrace: Add dump iteator > [PATCH] ftrace: Add debug_print trace to print data from kernel to userspace > [PATCH] ftrace: Add new entry type TRACE_BIN_DUMP > [PATCH] ftrace: Add debug_dump trace to dump binary data from kernel to userspace > [PATCH] Fix writing to trace/trace_options > > The patches are against -tip with HEAD > 7195b6707adcd00f413ce07e6b9954b4c597495c hm, i'm not sure about this. We already do binary dumping, but only for the cases where we actually know the structure of the data (i.e. binary dumping is just an output format, not a tracing type). And that is good so. In your patchset right now nothing uses debug_dump(ptr, len) so it's hard to see exactly how we should shape it. What specific usages do you have in mind? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/