Date: Mon, 17 Nov 2008 13:11:34 +0100
From: Jens Axboe <jens.axboe@oracle.com>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
       Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] cdrom: split mmc_ioctl to lower stack usage
Message-ID: <20081117121134.GM26778@kernel.dk>
References: <20081116180437.GC6282@joi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081116180437.GC6282@joi>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 706
Lines: 25

On Sun, Nov 16 2008, Marcin Slusarz wrote:
> Checkstack output:
> 
> Before:
> mmc_ioctl:                  584
> 
> After:
> mmc_ioctl_dvd_read_struct:  280
> mmc_ioctl_cdrom_subchannel: 152
> mmc_ioctl_cdrom_read_data:  120
> mmc_ioctl_cdrom_volume:     104
> mmc_ioctl_cdrom_read_audio: 104
> (mmc_ioctl is inlined into cdrom_ioctl - 104 bytes)

Looks good (both 1 and 2). What kind of testing have you done? I have
applied it to for-2.6.29.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/