Date: Mon, 17 Nov 2008 18:35:27 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Yinghai Lu <yinghai@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
       "H. Peter Anvin" <hpa@zytor.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: fix wakeup_cpu with numaq/es7000 v2
Message-ID: <20081117173527.GA2827@elte.hu>
References: <491FDE2A.1010809@kernel.org> <49200031.2040701@kernel.org> <20081117165224.GH12081@elte.hu> <20081117171157.GB7326@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081117171157.GB7326@localhost>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1447
Lines: 44


* Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> [Ingo Molnar - Mon, Nov 17, 2008 at 05:52:24PM +0100]
> | 
> | * Yinghai Lu <yinghai@kernel.org> wrote:
> | 
> | > Impact: fix wakeup path with numaq and es7000
> | 
> | applied	to tip/x86/quirks, thanks Yinghai!
> | 
> | A couple of comments:
> | 
> | > +static inline void inquire_remote_apic(int apicid)
> | > +{
> | > +	if (apic_verbosity >= APIC_DEBUG)
> | > +		__inquire_remote_apic(apicid);
> | > +}
> |
> 
> Btw, Ingo, Yinghai,
> 
> it's a bit weird but I found that we use apic_verbosity
> here to _do_ something (ie touching circuit) but on any
> other cases apic_verbosity is just a additional logging
> filter so -- what the initial apic_verbosity purpose was?
> If it's just a logging filter (to which I'm more biased)
> this case is plain wrong. But if apic_verbosity is not
> like this -- then it's fine. Since I was not initial author
> of the code -- I'm asking you :)

the reason why it's dependent on apic_verbosity is that the 
inquire_remote_apic() function is a debug function which we only call 
if we fail to start up a secondary CPU.

Perhaps renaming it to debug_print_remote_apic() would have made that 
more obvious.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/