Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754499AbYKQRgX (ORCPT ); Mon, 17 Nov 2008 12:36:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752465AbYKQRgN (ORCPT ); Mon, 17 Nov 2008 12:36:13 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:45942 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752261AbYKQRgM (ORCPT ); Mon, 17 Nov 2008 12:36:12 -0500 Date: Mon, 17 Nov 2008 09:35:25 -0800 (PST) From: Linus Torvalds To: Rik van Riel cc: KAMEZAWA Hiroyuki , KOSAKI Motohiro , Andrew Morton , LKML , linux-mm , Gene Heskett Subject: Re: [PATCH] vmscan: fix get_scan_ratio comment In-Reply-To: <4921A706.9030501@redhat.com> Message-ID: References: <20081115181748.3410.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20081115210039.537f59f5.akpm@linux-foundation.org> <49208E9A.5080801@redhat.com> <20081116204720.1b8cbe18.akpm@linux-foundation.org> <20081117153012.51ece88f.kamezawa.hiroyu@jp.fujitsu.com> <2f11576a0811162239w58555c6dq8a61ec184b22bd52@mail.gmail.com> <20081117155417.5cc63907.kamezawa.hiroyu@jp.fujitsu.com> <4921A1AF.1070909@redhat.com> <4921A706.9030501@redhat.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 915 Lines: 23 Grr. Don't use attachments. Now I can't sanely reply and quote things with a sane default setting (yes, I could set "include attachements in reply", but that is _not_ a sane default setting, and anybody who claims it is is a moron). Why don't people learn? Anyway, without quoting, the thing is - your fix isn't any better. The more interesting part is how the fractions get combined, and that is indeed approximately "anon% = anon / (anon + file)". So you in many ways made the comment worse. It wasn't good before, but it's still not good, and now it comments on the part that isn't even interesting (ie it comments the _trivial_ fractional part) Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/