Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754320AbYKQRwn (ORCPT ); Mon, 17 Nov 2008 12:52:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751589AbYKQRwc (ORCPT ); Mon, 17 Nov 2008 12:52:32 -0500 Received: from gv-out-0910.google.com ([216.239.58.186]:30325 "EHLO gv-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753696AbYKQRw2 (ORCPT ); Mon, 17 Nov 2008 12:52:28 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=qPh7izfJ5RXkKtY4XEpCXRBlDYHjqXzOqFli7ip2RUZlj3ZclMvclEduf/1tE/vHYe cXrt+vYB45yOqSNntgYSYf9zs0sxt9bQXeWgbuiXCKJW1o+g5xwQgE2sMRECBPMiW70t +QVzNSdYzHYBNfVuZy6OO086V8kOj+fuN0ja8= Date: Mon, 17 Nov 2008 20:52:23 +0300 From: Cyrill Gorcunov To: Ingo Molnar Cc: Yinghai Lu , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] x86: fix wakeup_cpu with numaq/es7000 v2 Message-ID: <20081117175223.GA5142@localhost> References: <491FDE2A.1010809@kernel.org> <49200031.2040701@kernel.org> <20081117165224.GH12081@elte.hu> <20081117171157.GB7326@localhost> <20081117173527.GA2827@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081117173527.GA2827@elte.hu> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1684 Lines: 51 [Ingo Molnar - Mon, Nov 17, 2008 at 06:35:27PM +0100] | | * Cyrill Gorcunov wrote: | | > [Ingo Molnar - Mon, Nov 17, 2008 at 05:52:24PM +0100] | > | | > | * Yinghai Lu wrote: | > | | > | > Impact: fix wakeup path with numaq and es7000 | > | | > | applied to tip/x86/quirks, thanks Yinghai! | > | | > | A couple of comments: | > | | > | > +static inline void inquire_remote_apic(int apicid) | > | > +{ | > | > + if (apic_verbosity >= APIC_DEBUG) | > | > + __inquire_remote_apic(apicid); | > | > +} | > | | > | > Btw, Ingo, Yinghai, | > | > it's a bit weird but I found that we use apic_verbosity | > here to _do_ something (ie touching circuit) but on any | > other cases apic_verbosity is just a additional logging | > filter so -- what the initial apic_verbosity purpose was? | > If it's just a logging filter (to which I'm more biased) | > this case is plain wrong. But if apic_verbosity is not | > like this -- then it's fine. Since I was not initial author | > of the code -- I'm asking you :) | | the reason why it's dependent on apic_verbosity is that the | inquire_remote_apic() function is a debug function which we only call | if we fail to start up a secondary CPU. | | Perhaps renaming it to debug_print_remote_apic() would have made that | more obvious. | | Ingo | Ah... I missed io_apic.c apic_verbosity usage, sorry for noise. It's all fine! Thanks. - Cyrill - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/