Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752303AbYKQSy5 (ORCPT ); Mon, 17 Nov 2008 13:54:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751279AbYKQSyt (ORCPT ); Mon, 17 Nov 2008 13:54:49 -0500 Received: from mx2.redhat.com ([66.187.237.31]:38222 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750922AbYKQSys (ORCPT ); Mon, 17 Nov 2008 13:54:48 -0500 Message-ID: <4921BDC5.4090303@redhat.com> Date: Mon, 17 Nov 2008 13:53:57 -0500 From: Rik van Riel Organization: Red Hat, Inc User-Agent: Thunderbird 2.0.0.17 (X11/20080915) MIME-Version: 1.0 To: Linus Torvalds CC: KAMEZAWA Hiroyuki , KOSAKI Motohiro , Andrew Morton , LKML , linux-mm , Gene Heskett Subject: Re: [PATCH] vmscan: fix get_scan_ratio comment References: <20081115181748.3410.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20081115210039.537f59f5.akpm@linux-foundation.org> <49208E9A.5080801@redhat.com> <20081116204720.1b8cbe18.akpm@linux-foundation.org> <20081117153012.51ece88f.kamezawa.hiroyu@jp.fujitsu.com> <2f11576a0811162239w58555c6dq8a61ec184b22bd52@mail.gmail.com> <20081117155417.5cc63907.kamezawa.hiroyu@jp.fujitsu.com> <4921A1AF.1070909@redhat.com> <4921A706.9030501@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 31 Linus Torvalds wrote: > Anyway, without quoting, the thing is - your fix isn't any better. The > more interesting part is how the fractions get combined, and that is > indeed approximately "anon% = anon / (anon + file)". Well, the "anon" and "file" in that calculation are the scanned/rotated ratios for anon and file pages, not the sizes of the lists. > So you in many ways made the comment worse. It wasn't good before, but > it's still not good, and now it comments on the part that isn't even > interesting (ie it comments the _trivial_ fractional part) How about something like the following: ? /* * The amount of pressure on anon vs file pages is inversely * proportional to the fraction of recently scanned pages on * each list that were recently referenced and in active use. */ (I'll mail the next patches out with claws-mail - silly thunderbird) -- All rights reversed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/