Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752472AbYKRII5 (ORCPT ); Tue, 18 Nov 2008 03:08:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751094AbYKRIIr (ORCPT ); Tue, 18 Nov 2008 03:08:47 -0500 Received: from vpn.id2.novell.com ([195.33.99.129]:3093 "EHLO vpn.id2.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbYKRIIr convert rfc822-to-8bit (ORCPT ); Tue, 18 Nov 2008 03:08:47 -0500 Message-Id: <49228648.76E4.0078.0@novell.com> X-Mailer: Novell GroupWise Internet Agent 8.0.0 Date: Tue, 18 Nov 2008 08:09:28 +0000 From: "Jan Beulich" To: "Alexander van Heukelum" Cc: "Ingo Molnar" , "Andi Kleen" , "Thomas Gleixner" , "Glauber Costa" , "LKML" , "Nick Piggin" , "H. Peter Anvin" Subject: Re: [RFC,v2] x86_64: save_args out of line References: <1226845741-12470-2-git-send-email-heukelum@fastmail.fm> <20081117175232.GA13766@mailshack.com> In-Reply-To: <20081117175232.GA13766@mailshack.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 816 Lines: 20 >>> Alexander van Heukelum 17.11.08 18:52 >>> >The macro "interrupt" in entry_64.S generates a lot of code and it >is used more and more often. This patch moves most of its contents >into an external function. This saves anywhere between 500 and 2500 >bytes of text depending on the configuration. Without numbers, I'd doubt that the code size reduction outweighs the overhead of the extra call. Did you do any measurements? >Dwarf2-annotations are most probably wrong or missing at all. Indeed - do you have intentions to address this? Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/