Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753334AbYKRISD (ORCPT ); Tue, 18 Nov 2008 03:18:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751918AbYKRIRA (ORCPT ); Tue, 18 Nov 2008 03:17:00 -0500 Received: from nwd2mail11.analog.com ([137.71.25.57]:52075 "EHLO nwd2mail11.analog.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751778AbYKRIQ6 (ORCPT ); Tue, 18 Nov 2008 03:16:58 -0500 X-IronPort-AV: E=Sophos;i="4.33,624,1220241600"; d="scan'208";a="62691574" From: Bryan Wu To: broonie@sirena.org.uk, tiwai@suse.de Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Michael Hennerich , Cliff Cai , Bryan Wu Subject: [PATCH 5/8] ASoC: Fix BUGS in Blackfin AC97 DAI Date: Tue, 18 Nov 2008 16:18:19 +0800 Message-Id: <1226996302-10234-6-git-send-email-cooloney@kernel.org> X-Mailer: git-send-email 1.5.6.3 In-Reply-To: <1226996302-10234-1-git-send-email-cooloney@kernel.org> References: <1226996302-10234-1-git-send-email-cooloney@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1029 Lines: 32 From: Michael Hennerich sport_handle is a global and not allocated my kmalloc. A probe function should have a clean return 0 path. Cc: Cliff Cai Signed-off-by: Michael Hennerich Signed-off-by: Bryan Wu --- sound/soc/blackfin/bf5xx-ac97.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/sound/soc/blackfin/bf5xx-ac97.c b/sound/soc/blackfin/bf5xx-ac97.c index 65c162c..5dcd3f6 100644 --- a/sound/soc/blackfin/bf5xx-ac97.c +++ b/sound/soc/blackfin/bf5xx-ac97.c @@ -378,6 +378,8 @@ static int bf5xx_ac97_probe(struct platform_device *pdev, goto sport_config_err; } + return 0; + sport_config_err: kfree(sport_handle); sport_err: -- 1.5.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/