Date: Tue, 18 Nov 2008 09:30:18 +0100
From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>
Cc: torvalds@linux-foundation.org, dada1@cosmosbay.com, rjw@sisk.pl,
       linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org,
       cl@linux-foundation.org, efault@gmx.de, a.p.zijlstra@chello.nl,
       shemminger@vyatta.com
Subject: Re: eth_type_trans(): Re: [Bug #11308] tbench regression on each
	kernel release from 2.6.22 -&gt; 2.6.28
Message-ID: <20081118083018.GI17838@elte.hu>
References: <20081117182320.GA26844@elte.hu> <20081117184951.GA5585@elte.hu> <20081117212657.GH12020@elte.hu> <20081117.211645.193706814.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081117.211645.193706814.davem@davemloft.net>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1219
Lines: 33


* David Miller <davem@davemloft.net> wrote:

> From: Ingo Molnar <mingo@elte.hu>
> Date: Mon, 17 Nov 2008 22:26:57 +0100
> 
> > eth->h_proto access.
> 
> Yes, this is the first time a packet is touched on receive.
> 
> > Given that this workload does localhost networking, my guess would be 
> > that eth->h_proto is bouncing around between 16 CPUs? At minimum this 
> > read-mostly field should be separated from the bouncing bits.
> 
> It's the packet contents, there is no way to "seperate it".
> 
> And it should be unlikely bouncing on your system under tbench, the 
> senders and receivers should hang out on the same cpu unless the 
> something completely stupid is happening.
> 
> That's why I like running tbench with a num_threads command line 
> argument equal to the number of cpus, every cpu gets the two thread 
> talking to eachother over the TCP socket.

yeah - and i posted the numbers for that too - it's the same 
throughput, within ~1% of noise.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/