Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754478AbYKRQOy (ORCPT ); Tue, 18 Nov 2008 11:14:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752964AbYKRQOp (ORCPT ); Tue, 18 Nov 2008 11:14:45 -0500 Received: from mx1.suse.de ([195.135.220.2]:60317 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752047AbYKRQOo (ORCPT ); Tue, 18 Nov 2008 11:14:44 -0500 Date: Tue, 18 Nov 2008 17:14:43 +0100 Message-ID: From: Takashi Iwai To: "Hannes Eder" Cc: "Jaroslav Kysela" , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: Fix warnings relating to ignored return value in snd_card_register In-Reply-To: <154e089b0811180759x4db4ba61k467fa2275710938f@mail.gmail.com> References: <154e089b0811180759x4db4ba61k467fa2275710938f@mail.gmail.com> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1632 Lines: 49 At Tue, 18 Nov 2008 16:59:03 +0100, Hannes Eder wrote: > > Do not ignore the return of 'device_create_file' in > 'snd_card_register' and thereby fixing the following warnings: > > sound/core/init.c: In function 'snd_card_register': > sound/core/init.c:640: warning: ignoring return value of > 'device_create_file', declared with attribute warn_unused_result > sound/core/init.c:641: warning: ignoring return value of > 'device_create_file', declared with attribute warn_unused_result The changes look good, but please run checkpatch.pl to your patch and fix the coding style issues suggested there. thanks, Takashi > > Signed-off-by: Hannes Eder > --- > sound/core/init.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/sound/core/init.c b/sound/core/init.c > index af1e407..814d834 100644 > --- a/sound/core/init.c > +++ b/sound/core/init.c > @@ -637,8 +637,10 @@ int snd_card_register(struct snd_card *card) > #endif > #ifndef CONFIG_SYSFS_DEPRECATED > if (card->card_dev) { > - device_create_file(card->card_dev, &card_id_attrs); > - device_create_file(card->card_dev, &card_number_attrs); > + if ((err = device_create_file(card->card_dev, &card_id_attrs)) < 0) > + return err; > + if ((err = device_create_file(card->card_dev, &card_number_attrs)) < 0) > + return err; > } > #endif > return 0; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/