DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=cc:message-id:from:to:in-reply-to:content-type
         :content-transfer-encoding:mime-version:subject:date:references
         :x-mailer;
        b=KocYGvHF1XIlr7176QvT8jOwD9NfVsiFwa6lMm/ekU0zCYeXpU+t468E0XuHRprvXb
         dmM0I3gNN/45bkeMgjcxL7hkEEZ1foN8pF6hjezNb5cKOhrihJnC6a7IH0fGSUXDZBoc
         nFdD6YPPj4RTCFRq0H8XZ287yzjeH+Xs6fAUA=
Cc: "Takashi Iwai" <tiwai@suse.de>, "Jaroslav Kysela" <perex@perex.cz>,
       kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Message-Id: <B39062E8-28BA-4701-A8A9-A25DA07482EA@gmail.com>
From: Richard Holden <aciddeath@gmail.com>
To: "Hannes Eder" <hannes@hanneseder.net>
In-Reply-To: <154e089b0811180906r69099866vf0b80cd40d7e2cc7@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v929.2)
Subject: Re: [PATCH] sound: Fix warnings relating to ignored return value in snd_card_register
Date: Tue, 18 Nov 2008 10:12:14 -0700
References: <154e089b0811180759x4db4ba61k467fa2275710938f@mail.gmail.com> <s5hej19dn9o.wl%tiwai@suse.de> <154e089b0811180906r69099866vf0b80cd40d7e2cc7@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1543
Lines: 40


On Nov 18, 2008, at 10:06 AM, Hannes Eder wrote:

> Do not ignore the return of 'device_create_file' in
> 'snd_card_register' and thereby fixing the following warnings:
>
> sound/core/init.c: In function 'snd_card_register':
> sound/core/init.c:640: warning: ignoring return value of
> 'device_create_file', declared with attribute warn_unused_result
> sound/core/init.c:641: warning: ignoring return value of
> 'device_create_file', declared with attribute warn_unused_result
>
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
> ---
>
> On Tue, Nov 18, 2008 at 11:14 AM, Takashi Iwai <tiwai@suse.de> wrote:
>> The changes look good, but please run checkpatch.pl to your patch and
>> fix the coding style issues suggested there.
>
> I did not fix:
>
> "WARNING: line over 80 characters" as they a hardly longer than 80
> characters and there are lines longer than this in the same file.
>
> "ERROR: do not use assignment in if condition" as this pattern seems
> to be quite common.
>
> Comments? Should I fix them?

I would definitely fix the ERROR, I have seen messages from Linus with  
really bad comments about using that construct. Most maintainers also  
won't want to take a patch where checkpatch reports an error. Also  
fixing the ERROR should also fix the warning.

-Richard Holden
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/