Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753565AbYKRRMy (ORCPT ); Tue, 18 Nov 2008 12:12:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754398AbYKRRMj (ORCPT ); Tue, 18 Nov 2008 12:12:39 -0500 Received: from mail.suse.de ([195.135.220.2]:35236 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754689AbYKRRMi (ORCPT ); Tue, 18 Nov 2008 12:12:38 -0500 Date: Tue, 18 Nov 2008 18:12:36 +0100 Message-ID: From: Takashi Iwai To: "Hannes Eder" Cc: "Jaroslav Kysela" , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: Fix warnings relating to ignored return value in snd_card_register In-Reply-To: <154e089b0811180906r69099866vf0b80cd40d7e2cc7@mail.gmail.com> References: <154e089b0811180759x4db4ba61k467fa2275710938f@mail.gmail.com> <154e089b0811180906r69099866vf0b80cd40d7e2cc7@mail.gmail.com> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1481 Lines: 46 At Tue, 18 Nov 2008 18:06:23 +0100, Hannes Eder wrote: > > Do not ignore the return of 'device_create_file' in > 'snd_card_register' and thereby fixing the following warnings: > > sound/core/init.c: In function 'snd_card_register': > sound/core/init.c:640: warning: ignoring return value of > 'device_create_file', declared with attribute warn_unused_result > sound/core/init.c:641: warning: ignoring return value of > 'device_create_file', declared with attribute warn_unused_result > > Signed-off-by: Hannes Eder > --- > > On Tue, Nov 18, 2008 at 11:14 AM, Takashi Iwai wrote: > > The changes look good, but please run checkpatch.pl to your patch and > > fix the coding style issues suggested there. > > I did not fix: > > "WARNING: line over 80 characters" as they a hardly longer than 80 > characters and there are lines longer than this in the same file. It's no excuse to add such lines again :) (But, don't try to clean up the other lines -- mostly not worth, and it'd just make the change history dirty.) > "ERROR: do not use assignment in if condition" as this pattern seems > to be quite common. Note this is an ERROR. > Comments? Should I fix them? Yes. thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/