DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=to:subject:content-disposition:from:date:cc:mime-version
         :content-type:content-transfer-encoding:message-id;
        b=pf5IZbMcPc5CMtxmyb7P28dXB0HKxkwdUfvkzBPbC0YSB220kv8qPzg9EDOwgh9iUV
         CJe6p9O9BoXenadhVfK5m9NR8tnGeMPhct54trDwQsjgzm2LWnYJLPCYF1/XFiSEzlfD
         1WZF13klvrIO8jzyNuLae5zrELsjTAiPrA7Vs=
To: Arjan van de Ven <arjan@infradead.org>
Subject: Re: [x86] do_arch_prctl - bug?
Content-Disposition: inline
From: Eric Lacombe <goretux@gmail.com>
Date: Tue, 18 Nov 2008 18:35:07 +0100
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
Message-Id: <200811181835.07360.goretux@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1482
Lines: 48

Le mardi 18 novembre 2008 15:45:56, vous avez ?crit?:
> On Tue, 18 Nov 2008 15:33:32 +0100
>
> Eric Lacombe <goretux@gmail.com> wrote:
> > Hello,
> >
> > I would like to know why the ARCH_SET_GS action of sys_arch_prctl,
> > write the MSR MSR_KERNEL_GS_BASE and not the MSR MSR_GS_BASE when the
> > variable "doit" equals 1? Is that a bug?
>
> I don't think it is.
> The trick is that we use "swapgs" on entering/leaving the kernel, and
> that will "swap" gs with the MSR, so when we return to userspace, GS
> gets loaded from the MSR_KERNEL_GS_BASE ...

Yeah when we enter the kernel swapgs is used, so the MSR_GS_BASE is switched 
with the MSR_KERNEL_GS_BASE.

In fact, what I certainly misunderstand is why load_gs_index use swapgs 
inside.
>From that function, I trust that only when gs is loaded, its hidden part is 
loaded with the MSR_GS_BASE.

ENTRY(native_load_gs_index)
        CFI_STARTPROC
        pushf
        CFI_ADJUST_CFA_OFFSET 8
        DISABLE_INTERRUPTS(CLBR_ANY | ~(CLBR_RDI))
        SWAPGS
gs_change:     
        movl %edi,%gs   
2:      mfence          /* workaround */
        SWAPGS
        popf
        CFI_ADJUST_CFA_OFFSET -8
        ret
        CFI_ENDPROC
ENDPROC(native_load_gs_index)

Regards,

	Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/