DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=qRbAHJsMGM3CYXRTyLeh6wQrWdTjHvUX4CYjwOe5qE9z2tYhrStcLPUdJsXw+cfiZ7
         MnmqJI+7YW8afAtLToYBB3WQoldpx/O5fkWUijyNISymBXXmX/zXFAHWMQUNYrWC258d
         tpCV9z3uTExyGcQj64NoFd8ndk/hPOnivbYR4=
Date: Tue, 18 Nov 2008 20:54:33 +0100
From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
       Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] cdrom: split mmc_ioctl to lower stack usage
Message-ID: <20081118195429.GA6010@joi>
References: <20081116180437.GC6282@joi> <20081117121134.GM26778@kernel.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081117121134.GM26778@kernel.dk>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 891
Lines: 27

On Mon, Nov 17, 2008 at 01:11:34PM +0100, Jens Axboe wrote:
> On Sun, Nov 16 2008, Marcin Slusarz wrote:
> > Checkstack output:
> > 
> > Before:
> > mmc_ioctl:                  584
> > 
> > After:
> > mmc_ioctl_dvd_read_struct:  280
> > mmc_ioctl_cdrom_subchannel: 152
> > mmc_ioctl_cdrom_read_data:  120
> > mmc_ioctl_cdrom_volume:     104
> > mmc_ioctl_cdrom_read_audio: 104
> > (mmc_ioctl is inlined into cdrom_ioctl - 104 bytes)
> 
> Looks good (both 1 and 2). What kind of testing have you done? I have
> applied it to for-2.6.29.

Only very basic testing - I can play audio cd's via amarok (CDROMREADRAW)
and kscd (CDROMREADAUDIO).

Marcin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/