Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754059AbYKRWcJ (ORCPT ); Tue, 18 Nov 2008 17:32:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752701AbYKRWb4 (ORCPT ); Tue, 18 Nov 2008 17:31:56 -0500 Received: from e33.co.us.ibm.com ([32.97.110.151]:42815 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752676AbYKRWbz (ORCPT ); Tue, 18 Nov 2008 17:31:55 -0500 Date: Tue, 18 Nov 2008 16:31:00 -0600 From: Michael Halcrow To: Leon Woestenberg Cc: linux-kernel@vger.kernel.org, pjssilva@ime.usp.br, akpm@linux-foundation.org, dustin.kirkland@gmail.com, sandeen@redhat.com Subject: Re: [PATCH] eCryptfs: Allocate up to two scatterlists for crypto ops on keys Message-ID: <20081118223100.GC6581@halcrowt61p.austin.ibm.com> Reply-To: Michael Halcrow References: <20081114164053.GC6624@halcrowt61p.austin.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 841 Lines: 25 On Fri, Nov 14, 2008 at 05:49:58PM +0100, Leon Woestenberg wrote: > Hello, > > On Fri, Nov 14, 2008 at 5:40 PM, Michael Halcrow wrote: > > > > - sg_init_table(&dst_sg, 1); > > - sg_init_table(&src_sg, 1); > > Why did you remove the inits? This initialization is done in virt_to_scatterlist() and is thus redundant for this function. > With self-checking enabled in the kernel, sg accessor functions will > check on proper initialization and BUGON(). > > It might be your use-case would not hit this, as it seems not to use > sg_ macro's much. > > Regards, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/