Date: Tue, 18 Nov 2008 15:41:28 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: tom.leiming@gmail.com, kay.sievers@vrfy.org, greg@kroah.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/ksysfs.c:fix dependence on CONFIG_NET
Message-Id: <20081118154128.56d1d3ca.akpm@linux-foundation.org>
In-Reply-To: <20081118153818.e623ba03.akpm@linux-foundation.org>
References: <1226830929-6610-1-git-send-email-tom.leiming@gmail.com>
	<20081118153818.e623ba03.akpm@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1871
Lines: 52

On Tue, 18 Nov 2008 15:38:18 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Sun, 16 Nov 2008 18:22:09 +0800
> tom.leiming@gmail.com wrote:
> 
> > From: Ming Lei <tom.leiming@gmail.com>
> > 
> > Access to uevent_seqnum and uevent_helper does not need to
> > depend on CONFIG_NET, so remove it.
> > 
> > Signed-off-by: Ming Lei <tom.leiming@gmail.com>
> > ---
> >  kernel/ksysfs.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/kernel/ksysfs.c b/kernel/ksysfs.c
> > index 08dd8ed..528dd78 100644
> > --- a/kernel/ksysfs.c
> > +++ b/kernel/ksysfs.c
> > @@ -24,7 +24,7 @@ static struct kobj_attribute _name##_attr = __ATTR_RO(_name)
> >  static struct kobj_attribute _name##_attr = \
> >  	__ATTR(_name, 0644, _name##_show, _name##_store)
> >  
> > -#if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET)
> > +#if defined(CONFIG_HOTPLUG)
> >  /* current uevent sequence number */
> >  static ssize_t uevent_seqnum_show(struct kobject *kobj,
> >  				  struct kobj_attribute *attr, char *buf)
> > @@ -137,7 +137,7 @@ struct kobject *kernel_kobj;
> >  EXPORT_SYMBOL_GPL(kernel_kobj);
> >  
> >  static struct attribute * kernel_attrs[] = {
> > -#if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET)
> > +#if defined(CONFIG_HOTPLUG)
> >  	&uevent_seqnum_attr.attr,
> >  	&uevent_helper_attr.attr,
> >  #endif
> 
> I think the story here is that uevent uses netlink, and with
> CONFIG_NET=n, we have no netlink, so that code couldn't do anything
> anyway.
> 

Or not.  Perhaps we can still use uevent_helper in this case?

(Getting a bit tired of writing people's changelogs for them!)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/