MIME-version: 1.0
Content-transfer-encoding: 7BIT
Content-type: TEXT/PLAIN; charset=US-ASCII
Date: Wed, 19 Nov 2008 03:33:52 +0100 (CET)
From: Michael Schmitz <schmitz@biophys.uni-duesseldorf.de>
Subject: Re: [PATCH 2/3] ide: add ide_[un]lock_hwgroup() helpers
In-reply-to: <200811182116.00351.bzolnier@gmail.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
       Geert Uytterhoeven <geert@linux-m68k.org>,
       Elias Oltmanns <eo@nebensachen.de>
Message-id: <alpine.DEB.1.00.0811190236550.24738@zirkon.biophys.uni-duesseldorf.de>
References: <200811182116.00351.bzolnier@gmail.com>
User-Agent: Alpine 1.00 (DEB 882 2007-12-20)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 736
Lines: 19

> -	while (!hwgroup->busy) {
> -		hwgroup->busy = 1;
> -		/* for atari only */
> -		ide_get_lock(ide_intr, hwgroup);
> +	while (!ide_lock_hwgroup(hwgroup)) {

Something I've run into while working on the locking stuff: what happens if the 
above ide_lock_hwgroup(hwgroup) sleeps for long enough to trigger the request 
timer? 

I'll think about the ramifications of your patch in the context of what I tested 
WRT unlocking whenever hwgroup->busy is cleared, and get back to you. 

	Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/