Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753569AbYKSNm5 (ORCPT ); Wed, 19 Nov 2008 08:42:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752962AbYKSNmt (ORCPT ); Wed, 19 Nov 2008 08:42:49 -0500 Received: from stag.SEAS.UPENN.EDU ([158.130.70.79]:47173 "EHLO stag.seas.upenn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752838AbYKSNms (ORCPT ); Wed, 19 Nov 2008 08:42:48 -0500 Message-ID: <492417D4.4090103@seas.upenn.edu> Date: Wed, 19 Nov 2008 08:42:44 -0500 From: Rafi Rubin User-Agent: Mozilla-Thunderbird 2.0.0.17 (X11/20081018) MIME-Version: 1.0 To: Jiri Kosina CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] n-trig digitizer quirks References: <49232910.2030309@seas.upenn.edu> In-Reply-To: X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1434 Lines: 38 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 > Could you please keep standard linux-kernel indenting style? I.e. > something like Sorry, just had different settings in my vimrc for something else. > > >> + >> +static int ntrig_input_mapped(struct hid_device *hdev, struct hid_input *hi, >> + struct hid_field *field, struct hid_usage *usage, >> + unsigned long **bit, int *max) >> +{ >> + unsigned long quirks = (unsigned long)hid_get_drvdata(hdev); > > This could be removed, as it is never used, right? Yes, it wasn't used at the moment, just something left over from using hid-lg.c as a template. Since this is the only device known for this driver at this point, is it better to keep it shorter and not check for the duplicate usage from the driver data or would it be better to add the flexibility now? Also, if you do prefer using driver data like that, is the probe function necessary to make it work? Rafi -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkkkF9IACgkQwuRiAT9o6088RgCfdvu6ntRJ11vh5Ti2CHG+PJJz SWcAoLrViuX6HO+wEaJnCS+Yt95nAr0D =qepn -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/