Date: Wed, 19 Nov 2008 11:33:50 -0500 (EST)
From: Alan Stern <stern@rowland.harvard.edu>
To: Jens Axboe <jens.axboe@oracle.com>
cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
       "Hommel, Thomas (GE EntSol, Intelligent Platforms)" 
	<Thomas.Hommel@gefanuc.com>,
       USB list <linux-usb@vger.kernel.org>,
       Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: ISP1760 driver crashes
In-Reply-To: <20081119153923.GR26308@kernel.dk>
Message-ID: <Pine.LNX.4.44L0.0811191131320.2418-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1090
Lines: 31

On Wed, 19 Nov 2008, Jens Axboe wrote:

> > --- usb-2.6.orig/drivers/scsi/scsi_lib.c
> > +++ usb-2.6/drivers/scsi/scsi_lib.c
> > @@ -1684,7 +1684,7 @@ static void scsi_request_fn(struct reque
> >  u64 scsi_calculate_bounce_limit(struct Scsi_Host *shost)
> >  {
> >  	struct device *host_dev;
> > -	u64 bounce_limit = 0xffffffff;
> > +	u64 bounce_limit = BLK_BOUNCE_HIGH;
> >  
> >  	if (shost->unchecked_isa_dma)
> >  		return BLK_BOUNCE_ISA;
> > 
> 
> The best solution is probably to either provide a "doesn't do highmem"
> in the scsi host template, or provide an appropriate DMA mask for the
> pci device to indicate it through that setting instead.

The DMA mask is currently set to NULL.  Is that not appropriate for a 
device that can't do DMA?  If not, then what would be appropriate?

Also, is the patch above not correct?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/