Message-ID: <ac3eb2510811190900k62b1333aj9816e462601b4d0c@mail.gmail.com>
Date: Wed, 19 Nov 2008 18:00:37 +0100
From: "Kay Sievers" <kay.sievers@vrfy.org>
To: "rae l" <crquan@gmail.com>
Subject: Re: [PATCH] kobject_add: use constant strings directly as fmt strings
Cc: "Greg KH" <gregkh@suse.de>, "Jens Axboe" <jens.axboe@oracle.com>,
       linux-kernel@vger.kernel.org
In-Reply-To: <91b13c310811190817s31522a0et744ca7df2782cf27@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1227110059-12529-1-git-send-email-crquan@gmail.com>
	 <20081119155736.GA5072@suse.de>
	 <91b13c310811190817s31522a0et744ca7df2782cf27@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1024
Lines: 28

On Wed, Nov 19, 2008 at 17:17, rae l <crquan@gmail.com> wrote:
> On Wed, Nov 19, 2008 at 11:57 PM, Greg KH <gregkh@suse.de> wrote:
>>>       ret = kobject_add(&q->kobj, kobject_get(&disk_to_dev(disk)->kobj),
>>> -                       "%s", "queue");
>>> +                       "queue");
>>
>> Why?  What does this change buy us?
>
> Dropping one parameter makes the function call a little faster, doesn't it?
>
> The results are the same,

Not that we should be able to measure it, but it should save some
cycles parsing the format character and retrieving the string pointer
from the stack, yes.

> so if the string is constant, why not use it directly as the fmt string?

It should be fine for strings, where you can be sure they can never
contain a '%', sure.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/