Date: Wed, 19 Nov 2008 18:39:46 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ken Chen <kenchen@google.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] sched: fix inconsistency when redistribute per-cpu
	tg->cfs_rq  shares.
Message-ID: <20081119173946.GA31560@elte.hu>
References: <b040c32a0811182241r3cf5e7c7l25d3627c2265ead2@mail.gmail.com> <1227113269.29743.43.camel@lappy.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1227113269.29743.43.camel@lappy.programming.kicks-ass.net>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1665
Lines: 39


* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:

> On Tue, 2008-11-18 at 22:41 -0800, Ken Chen wrote:
> > In the update_shares() path leading to tg_shares_up(), the calculation of
> > per-cpu cfs_rq shares is rather erratic even under moderate task wake up
> > rate.  The problem is that the per-cpu tg->cfs_rq load weight used in the
> > sd_rq_weight aggregation and actual redistribution of the cfs_rq->shares
> > are collected at different time.  Under moderate system load, we've seen
> > quite a bit of variation on the cfs_rq->shares and ultimately wildly
> > affects sched_entity's load weight.
> 
> Another thing we could possibly do is put a low-pass filter on the
> per-cpu load values so that we smooth out the fluctuations, hmm?
> 
> > This patch caches the result of initial per-cpu load weight when doing the
> > sum calculation, and then pass it down to update_group_shares_cpu() for
> > redistributing per-cpu cfs_rq shares.  This allows consistent total cfs_rq
> > shares across all CPUs. It also simplifies the rounding and zero load
> > weight check.
> > 
> > Signed-off-by: Ken Chen <kenchen@google.com>
> 
> This does indeed look much better, the cleanup factor alone makes it 
> a worthwhile patch, he fact that is improves behaviour makes it even 
> better :-)
> 
> Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> 
> Thanks Ken!

applied to tip/sched/core (for v2.6.29), thanks guys!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/