Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753016AbYKSXiu (ORCPT ); Wed, 19 Nov 2008 18:38:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752027AbYKSXim (ORCPT ); Wed, 19 Nov 2008 18:38:42 -0500 Received: from ozlabs.org ([203.10.76.45]:32920 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752018AbYKSXil (ORCPT ); Wed, 19 Nov 2008 18:38:41 -0500 From: Rusty Russell To: Hiroshi Shimamoto Subject: Re: [PATCH 1/1] cpumask: smp_call_function_many() Date: Thu, 20 Nov 2008 10:08:31 +1030 User-Agent: KMail/1.10.1 (Linux/2.6.27-7-generic; KDE/4.1.2; i686; ; ) Cc: linux-kernel@vger.kernel.org, Mike Travis , schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, npiggin@suse.de, axboe@kernel.dk References: <20081119144710.59CA1DDDDB@ozlabs.org> <492475BF.6090502@ct.jp.nec.com> In-Reply-To: <492475BF.6090502@ct.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200811201008.31978.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 583 Lines: 20 On Thursday 20 November 2008 06:53:27 Hiroshi Shimamoto wrote: > Rusty Russell wrote: > > + /* Fastpath: do that cpu by itself. */ > > + if (next_cpu >= nr_cpu_ids) > > + smp_call_function_single(cpu, func, info, wait); > > Hi Rusty, > > I think, return is needed here. If not func will be called twice. Indeed, thanks! Fixed, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/