Date: Thu, 20 Nov 2008 10:59:43 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
       Andrew Morton <akpm@linux-foundation.org>,
       "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 0/2 v3] SGI RTC: add clocksource/clockevent driver and
	generic timer vector
Message-ID: <20081120095943.GF6885@elte.hu>
References: <20081023163041.GA14574@sgi.com> <20081119212202.GA3377@sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081119212202.GA3377@sgi.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1074
Lines: 29


* Dimitri Sivanich <sivanich@sgi.com> wrote:

> The following patches provide a driver for synchronized RTC 
> clocksource and clockevents for SGI systems, as well as a generic 
> timer system interrupt.
> 
> With these patches, a module can be installed that registers the 
> system-wide synchronized RTC clocksource and timers as both a 
> clocksource and clockevents device running in high resolution mode.
> 
> [PATCH 1/2 v3] SGI RTC: add clocksource driver
> [PATCH 2/2 v3] SGI RTC: add generic timer system interrupt

Looks very clean and well-done to me.

I had to take a good look at the rtc_timer_head->expires[] construct - 
but i guess that's the best approach, as the max number of entries is 
hard to judge at build time. (and we wont get any real limit 
protection from gcc anyway)

Thomas, any objections?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/