Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755815AbYKTOhy (ORCPT ); Thu, 20 Nov 2008 09:37:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754828AbYKTOhq (ORCPT ); Thu, 20 Nov 2008 09:37:46 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:51178 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754794AbYKTOhp (ORCPT ); Thu, 20 Nov 2008 09:37:45 -0500 Subject: Re: [PATCH] intel-iommu: make init_dmars() static From: David Woodhouse To: Mark McLoughlin Cc: Ingo Molnar , linux-kernel , iommu@lists.linux-foundation.org In-Reply-To: <1227191049.3739.28.camel@blaa> References: <1227190873.3739.24.camel@blaa> <1227191049.3739.28.camel@blaa> Content-Type: text/plain Date: Thu, 20 Nov 2008 14:37:41 +0000 Message-Id: <1227191861.4901.24.camel@macbook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 820 Lines: 22 On Thu, 2008-11-20 at 14:24 +0000, Mark McLoughlin wrote: > On Thu, 2008-11-20 at 14:21 +0000, Mark McLoughlin wrote: > > init_dmars() is not used outside of drivers/pci/intel-iommu.c > > Note, most of linux/dma_remapping.h is only needed by intel-iommu.c Most. > Any objections into moving all of that into intel-iommu.c? That would seem to make sense. Don't forget to check IA64 when declaring stuff unused though :) -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/